gtully commented on code in PR #5407: URL: https://github.com/apache/activemq-artemis/pull/5407#discussion_r1888715162
########## artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/kubernetes/client/KubernetesClientImpl.java: ########## @@ -160,9 +163,13 @@ private SSLContext buildSSLContext() throws Exception { try (InputStream fis = new FileInputStream(certFile)) { KeyStore trustStore = KeyStore.getInstance(KeyStore.getDefaultType()); Review Comment: I think it would make sense to lean on the PEM keyStoreType support, and make use of SSLSupport utility calss to load a trust store. In that way, this ssl client will behave like the others in the broker. When this client was introduced there was no support for PEM in the broker, but now there is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact