gemmellr commented on code in PR #5407: URL: https://github.com/apache/activemq-artemis/pull/5407#discussion_r1890265382
########## tests/security-resources/client-and-server-ca-cert.pem: ########## @@ -0,0 +1,42 @@ +-----BEGIN CERTIFICATE----- Review Comment: Since adding this file, which is only copying/using existing certs, is the only real change needed beyond the build.sh script...I think we should just avoid regenerating the whole set of files this time to minimise the overall change and make more obvious the effect of the actual change, i.e you can just revert the changes to all the other security-resources files except those two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
