mattrpav commented on code in PR #1329:
URL: https://github.com/apache/activemq/pull/1329#discussion_r1920661468


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -1971,10 +1978,17 @@ private final boolean tryCursorAdd(final Message msg) 
throws Exception {
 
     final void messageSent(final ConnectionContext context, final Message msg) 
throws Exception {
         pendingSends.decrementAndGet();
+
         destinationStatistics.getEnqueues().increment();
         destinationStatistics.getMessages().increment();
         destinationStatistics.getMessageSize().addSize(msg.getSize());
 
+        MessageFlowStats tmpMessageFlowStats = 
destinationStatistics.getMessageFlowStats();
+
+        if(isAdvancedMessageStatisticsEnabled() && tmpMessageFlowStats != 
null) {

Review Comment:
   Resolved w/ cshannon's commit



##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java:
##########
@@ -186,6 +177,11 @@ public void reset() {
             maxUncommittedExceededCount.reset();
             networkEnqueues.reset();
             networkDequeues.reset();
+
+            MessageFlowStatsImpl tmpMessageFlowStats = messageFlowStats;

Review Comment:
   Resolved w/ cshannon's commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to