mattrpav commented on code in PR #1329: URL: https://github.com/apache/activemq/pull/1329#discussion_r1924507072
########## activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java: ########## @@ -252,7 +242,29 @@ public void setParent(DestinationStatistics parent) { maxUncommittedExceededCount.setParent(null); networkEnqueues.setParent(null); networkDequeues.setParent(null); + // [AMQ-9437] Advanced Message Statistics do not parent. } } + // This is the only method that can mutate the messageFlowStats state + // so we only need to synchronize this method to make sure we don't have 2 threads + // trying to set at the same time. + public synchronized void setAdvancedMessageStatisticsEnabled(boolean enabled) { + // we can just use the get() here on the reference as no other spot can Review Comment: Comment removed via commit c079d1bd03df5a2faf35f2ec9625e7e51b2a4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact