alxgomz commented on PR #1378:
URL: https://github.com/apache/activemq/pull/1378#issuecomment-2601730174
Hi @mattrpav thanks for taking the time to review.
1. Toggling JMX on and off is actually the very lightweight part of this PR.
To be honest I have introduced it because I wanted to keep a similar behaviour
to what pre-existed. But I would personally remove it completely given, a) JMX
is such a pain in most docker environments and really not well suited to NAT
networks in general and b) the authentication as it is set right now simply
doesn't work: even if user and password are set one can still login anonymously
as soon as the `createConnector` param is set t io true (btw, the doc seems to
mention the jmx authenticated access should be set up using java OPTS and with
the `ManagementContext` turned off but I could not get it to work). And c) I
remember reading theere's a jolokia endpoint available somewhere that would
deliver just the same data in a more friendly fashion. But I decided I would
not make this kind more disruptive approach.
2. The reason I did not used JaaS to configure web user s because I'm
working with ActiveMQ 5.18 which do not seem to have the appropriate classes
available and throws this error when trying to do use it:
```
ERROR | Failed to load: class path resource [activemq.xml], reason: Failed
to load type: org.eclipse.jetty.jaas.JAASLoginService. Reason: java.lang.Cl
assNotFoundException: org.eclipse.jetty.jaas.JAASLoginService; nested
exception is java.lang.ClassNotFoundException: org.eclipse.jetty.jaas.JAASLoginS
ervice
org.springframework.beans.factory.BeanDefinitionStoreException: Failed to
load type: org.eclipse.jetty.jaas.JAASLoginService. Reason: java.lang.ClassN
otFoundException: org.eclipse.jetty.jaas.JAASLoginService; nested exception
is java.lang.ClassNotFoundException: org.eclipse.jetty.jaas.JAASLoginServi
ce
```
Taking a look at the 5.x distribution I saw the default user was using
jetty-realm properties file which was only available in 5.x dists so I chose to
rely on the presence of this file to decide wether I would set the default web
user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
