jbonofre commented on PR #1378: URL: https://github.com/apache/activemq/pull/1378#issuecomment-2639890846
> > I'm sorry, but I don't understand the overall purpose. What's exactly the problem statement ? > > Sorry if that's not clear. What I'm trying to do here is to produce an image which will: > > * run as non root user by default > * have a more robust configuration stage (mainly using a true xml parser rather than sed-ing in xml) > * leverage java system properties where possible instead of modifying files on the fly with the entrypoint > > That's mainly to conform to 2 container best practices: to not run as root and to not run container with a read-only fs Ok, it's clearer for me now. As I see more than "just" non root privileges, it wasn't obvious to me. Let me do a new review/pass (fyi, I'm the original author of the Docker image build). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
