gemmellr commented on code in PR #5441:
URL: https://github.com/apache/activemq-artemis/pull/5441#discussion_r1925182844
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/hawtio-oidc.properties:
##########
@@ -0,0 +1,76 @@
+#
Review Comment:
Its not clear to me we should create this file by default? The main reason
it seemed to first be added in earlier PR was because Hawtio 4.0.0 logged a
warning if it wasn't found, and the console 1.0.0 version from earlier variants
of this PR used 4.0.0. That logging was changed to debug in 4.1.0, and the
newer 1.1.0 console used in this PR uses 4.2.0, so should it go?
##########
artemis-distribution/pom.xml:
##########
@@ -117,15 +117,12 @@
<artifactId>artemis-console</artifactId>
<type>war</type>
</dependency>
+ <!-- needed for console NPM License-->
<dependency>
<groupId>org.apache.activemq</groupId>
- <artifactId>activemq-branding</artifactId>
- <type>war</type>
- </dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-plugin</artifactId>
- <type>war</type>
+ <artifactId>apache-artemis-console</artifactId>
+ <type>zip</type>
+ <classifier>bin</classifier>
Review Comment:
The changes in the pom overall result in inclusion of the console zip and
the war in the distribution lib dir.
This should probably marked as provided as its only here for build time use
(or maybe it could even be omitted, given it is specified in the dependency
unpack execution)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
