gemmellr commented on code in PR #5467:
URL: https://github.com/apache/activemq-artemis/pull/5467#discussion_r1942682365
##########
artemis-distribution/pom.xml:
##########
@@ -117,15 +117,12 @@
<artifactId>artemis-console</artifactId>
<type>war</type>
</dependency>
+ <!-- needed for console NPM License-->
<dependency>
<groupId>org.apache.activemq</groupId>
- <artifactId>activemq-branding</artifactId>
- <type>war</type>
- </dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-plugin</artifactId>
- <type>war</type>
+ <artifactId>apache-artemis-console</artifactId>
+ <type>zip</type>
+ <classifier>bin</classifier>
Review Comment:
Carried over comment (there are others) from previous PR:
(Thinking on it again, I think removing it should probably be the way to go)
> The changes in the pom overall result in inclusion of the console zip and
the war in the distribution lib dir.
>
> This should probably marked as provided as its only here for build time
use (or maybe it could even be omitted, given it is specified in the dependency
unpack execution)
https://github.com/apache/activemq-artemis/pull/5441#discussion_r1925247633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
