jbertram commented on PR #5504:
URL: 
https://github.com/apache/activemq-artemis/pull/5504#issuecomment-2656865958

   My only concern with this PR is that some fields in `QueueImpl` which were 
`volatile` have been replaced with ones from `QueueConfiguration` which are 
not. That said, the full test-suite is green on this so it's not clear that 
actually makes a difference. I would love feedback on this point specifically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to