clebertsuconic commented on PR #5504: URL: https://github.com/apache/activemq-artemis/pull/5504#issuecomment-2657145560
I looked now and it looks good to me. I don't think the volatile was needed. The place where it's being used (QueueImpl.addConsumer) is under a synchronized block. One thing that bothered me was beyond the scope of this PR.. as Queueimpl.addConsumer is called within ServerConsumerImpl... but that goes beyond the scope of this PR. I don't have any issues with this PR if tests are good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
