clebertsuconic commented on PR #5510: URL: https://github.com/apache/activemq-artemis/pull/5510#issuecomment-2694998571
@jbertram one thing that failed very badly for us in the past was the practice of extending tests and duplicating them.. A test that was originally intended for something, then we duplicate the tests with something else. I would prefer if we add just a single test validating the commit interval instead of repeating all the ones from the top. I had done a lot of cleanup recently to remove things like this.. I would prefer if we don't do this kind of thing now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
