clebertsuconic commented on code in PR #5510:
URL: https://github.com/apache/activemq-artemis/pull/5510#discussion_r1978166188
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImplTest.java:
##########
@@ -962,6 +963,7 @@ private void
checkScaleDownConfiguration(ScaleDownConfiguration scaleDownConfigu
assertEquals("g0", scaleDownConfiguration.getGroupName());
assertEquals("c0", scaleDownConfiguration.getClusterName());
assertFalse(scaleDownConfiguration.isEnabled());
+ assertEquals(33, scaleDownConfiguration.getCommitInterval());
Review Comment:
a very tiny request.. can you use a different constant here? you used 33 on
the XML... if the XML is parsed by accident in the test you wouldn't know if
the value came from the XML or the properties.
If you okay with merging this now I can make this change myself with a git
checkout and push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
