gemmellr commented on code in PR #5547:
URL: https://github.com/apache/activemq-artemis/pull/5547#discussion_r1987060887
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/ssl/SSLSupport.java:
##########
@@ -352,11 +352,14 @@ public static KeyStore loadKeystore(final String
keystoreProvider,
return ks;
}
- public static void checkPemProviderLoaded(String keystoreType) {
+ /**
+ * This method calls out to a separate class in order to avoid a hard
dependency on the provider's implementation.
+ * This allows folks who don't use PEM to avoid using the corresponding
dependency.
+ */
+ public static void checkPemProviderLoaded(String keystoreType) throws
Exception {
Review Comment:
Is the signature reallyneeded anymore, now the reflection is gone?
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/ssl/SSLSupport.java:
##########
@@ -352,11 +352,14 @@ public static KeyStore loadKeystore(final String
keystoreProvider,
return ks;
}
- public static void checkPemProviderLoaded(String keystoreType) {
+ /**
+ * This method calls out to a separate class in order to avoid a hard
dependency on the provider's implementation.
+ * This allows folks who don't use PEM to avoid using the corresponding
dependency.
+ */
+ public static void checkPemProviderLoaded(String keystoreType) throws
Exception {
Review Comment:
Is the signature really needed anymore, now the reflection is gone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
