cshannon commented on PR #1410: URL: https://github.com/apache/activemq/pull/1410#issuecomment-2734331301
I was testing things out with the different destination creation scenarios and saw the exception pop up each time so I assumed it was short circuiting the creation attempt. It was only doing so partially and leaving things half initialized, I went back and looked and it is first initializing and adding the destination to the store and then exploding with the errors when the interceptor is later applied which is why you are seeing the errors. The code first creates the destination including adding it to the datastore [here](https://github.com/apache/activemq/blob/9964c95ffef07c73ee4d702c817da6642ff1938e/activemq-broker/src/main/java/org/apache/activemq/broker/region/AbstractRegion.java#L157) and later when the interceptor wraps the destination and throws an exception and blows up we run into this same problem. It's breaking at [this](https://github.com/apache/activemq/blob/9964c95ffef07c73ee4d702c817da6642ff1938e/activemq-broker/src/main/java/org/apache/activemq/broker/region/AbstractRegion.java#L161) line which causes the rest of the code block not to process...so the destination is not started and it's not added into the map but the store is still created. The real fix would be to just prevent destination creation entirely in this scenario. This is actually a bigger issue in that if any other interceptor breaks we run into the same problem. I have a small prototype I'm working on that I will push up and see what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
