cshannon commented on PR #1410: URL: https://github.com/apache/activemq/pull/1410#issuecomment-2734523527
@graben - Ok I think you win, i made a proof of concept that catches the error and cleans up the initialized destination in the store but the issue that I realized is that there might be existing data that we could be blowing away as it may not be a brand new destination. It would be too dangerous to assume any error means we can just go dispose of the destination in the store as we don't know the exact issue. In this case the error is fatal on creation, but there could be lots of other interceptors that might have a more transient error that could be recovered from. In the grand scheme of things, your change is probably fine. The side effect is if someone creates the wrong destination name with a missing virtual topic name, it's not great but there's not really any harm other then you end up with an extra destination with a typo and at least that is easily recovered from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
