jbertram opened a new pull request, #5607: URL: https://github.com/apache/activemq-artemis/pull/5607
This commit improves performance specifically for removing listeners from o.a.a.a.c.s.i.HierarchicalObjectRepository. It was previously using an ArrayList and the cost to remove an Object is O(n) on average whereas the same operation on a HashSet is O(1) on average assuming good hash values. Furthermore, the list was protected using a ReentrantReadWriteLock. However, by using a ConcurrentHashSet we can eliminate these locks further improving performance. Switching to a ConcurrentHashSet required a few changes to the listeners themselves to ensure they have good hashCodes, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
