brusdev commented on code in PR #5607:
URL: https://github.com/apache/activemq-artemis/pull/5607#discussion_r2031133450
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -415,8 +418,16 @@ public QueueImpl(final QueueConfiguration
queueConfiguration,
scheduledDeliveryHandler = new
ScheduledDeliveryHandlerImpl(scheduledExecutor, this);
if (addressSettingsRepository != null) {
- addressSettingsRepositoryListener = new
AddressSettingsRepositoryListener(addressSettingsRepository);
-
addressSettingsRepository.registerListener(addressSettingsRepositoryListener);
+ this.addressSettingsRepository = addressSettingsRepository;
+ addressSettingsRepositoryListener = new
NamedHierarchicalRepositoryChangeListener(queueConfiguration.getName()) {
Review Comment:
A name prefix could help to identify the listener owner and avoid conflicts
between retroactive addresses and queues with the same name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
