gtully commented on code in PR #5603:
URL: https://github.com/apache/activemq-artemis/pull/5603#discussion_r2034850966
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/TransportConfiguration.java:
##########
@@ -239,6 +239,17 @@ public boolean isSameParams(TransportConfiguration that) {
return true;
}
+ public boolean isSameTarget(TransportConfiguration otherConfig) {
+ if (this.getFactoryClassName().contains("Netty") &&
otherConfig.getFactoryClassName().contains("Netty")) {
+ return Objects.equals(this.params.get("host"),
otherConfig.params.get("host")) &&
Review Comment:
does dns resolution come into play for the comparison? if a host is
resolvable under two ips, would we try and cluster twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
