brusdev commented on code in PR #5603:
URL: https://github.com/apache/activemq-artemis/pull/5603#discussion_r2042302335


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/TransportConfiguration.java:
##########
@@ -239,6 +239,17 @@ public boolean isSameParams(TransportConfiguration that) {
       return true;
    }
 
+   public boolean isSameTarget(TransportConfiguration otherConfig) {
+      if (this.getFactoryClassName().contains("Netty") && 
otherConfig.getFactoryClassName().contains("Netty")) {
+         return Objects.equals(this.params.get("host"), 
otherConfig.params.get("host")) &&

Review Comment:
   I added a check for the resolved addresses when the ports match and the host 
names don't match.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to