tabish121 commented on code in PR #5646:
URL: https://github.com/apache/activemq-artemis/pull/5646#discussion_r2054950611
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTimedWriter.java:
##########
@@ -118,15 +120,15 @@ public void incrementTask() {
pendingTasksUpdater.incrementAndGet(this);
}
- public void addTask(OperationContext context,
+ public int addTask(OperationContext context,
PagedMessage message,
Transaction tx,
- RouteContextList listCtx) {
+ RouteContextList listCtx, boolean
useFlowControl) {
logger.trace("Adding paged message {} to paged writer", message);
int credits = Math.min(message.getEncodeSize() +
PageReadWriter.SIZE_RECORD, maxCredits);
- writeCredits.acquireUninterruptibly(credits);
+ //writeCredits.acquireUninterruptibly(credits);
Review Comment:
Commented out code is usually confusing for future maintenance, recommend
removing this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
