gemmellr commented on code in PR #5646:
URL: https://github.com/apache/activemq-artemis/pull/5646#discussion_r2055855161
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTimedWriter.java:
##########
@@ -118,15 +120,18 @@ public void incrementTask() {
pendingTasksUpdater.incrementAndGet(this);
}
- public void addTask(OperationContext context,
+ public int addTask(OperationContext context,
PagedMessage message,
Transaction tx,
- RouteContextList listCtx) {
+ RouteContextList listCtx, boolean
useFlowControl) {
logger.trace("Adding paged message {} to paged writer", message);
+ // the module using the page operation should later call flowControl
from this class.
+ // the only exception to this would be from tests where we don't really
care about flow control on the TimedExecutor
+ // also: the credits is based on the page size, and we use the
encodeSize to flow it.
int credits = Math.min(message.getEncodeSize() +
PageReadWriter.SIZE_RECORD, maxCredits);
- writeCredits.acquireUninterruptibly(credits);
+
Review Comment:
This line removed acquisition of credit, but the lines immediately below
still have what looks like a compensating-release of credit if not started.
Should that go now?
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTimedWriter.java:
##########
@@ -118,15 +120,18 @@ public void incrementTask() {
pendingTasksUpdater.incrementAndGet(this);
}
- public void addTask(OperationContext context,
+ public int addTask(OperationContext context,
PagedMessage message,
Transaction tx,
- RouteContextList listCtx) {
+ RouteContextList listCtx, boolean
useFlowControl) {
logger.trace("Adding paged message {} to paged writer", message);
+ // the module using the page operation should later call flowControl
from this class.
+ // the only exception to this would be from tests where we don't really
care about flow control on the TimedExecutor
+ // also: the credits is based on the page size, and we use the
encodeSize to flow it.
int credits = Math.min(message.getEncodeSize() +
PageReadWriter.SIZE_RECORD, maxCredits);
- writeCredits.acquireUninterruptibly(credits);
+
Review Comment:
This line change removed acquisition of credit, but the lines immediately
below still have what looks like a compensating-release of credit if not
started. Should that go now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
