gtully commented on code in PR #5653:
URL: https://github.com/apache/activemq-artemis/pull/5653#discussion_r2063838031
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -747,7 +747,7 @@ public void refUp(MessageReference messageReference) {
}
}
if (pagingStore != null) {
- if (owner != null && pagingStore != owner) {
+ if (isInternalQueue() && owner != null && pagingStore != owner) {
Review Comment:
a cluster connection snfq is internal, i wonder if this is really the right
gate?
a mirror takes a copy, which make it different, but I would still expect
pending mirror messages of address X to be visible on address usage for X,
rather than pending on the mirror snf. It sort of shifts the monitoring burden
when mirroring is in play, but it does make is clear what is responsible for
holding the reference.
I think a possible gate would be isMirrorQueue, or the message copy impl
takes account of the owning pagestore. Not sure what is best but I think
possibly isInternal will be too broad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
