clebertsuconic commented on code in PR #5653:
URL: https://github.com/apache/activemq-artemis/pull/5653#discussion_r2064777296


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -747,7 +747,7 @@ public void refUp(MessageReference messageReference) {
          }
       }
       if (pagingStore != null) {
-         if (owner != null && pagingStore != owner) {
+         if (isInternalQueue() && owner != null && pagingStore != owner) {

Review Comment:
   we could do that for only mirrors... but I think it would make sense on the 
Cluster SNF as well (to account the copy).. that would make the cluster SNF to 
go paging earlier  and that would be better (like it was the case for 
Mirroring).
   
   I guess it makes sense to add tests on the clustering case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to