jbertram commented on PR #5706: URL: https://github.com/apache/activemq-artemis/pull/5706#issuecomment-2904951254
This PR has several problems which prevent merging: - It is changing the default behavior. This can't be done in a minor release. The current behavior should be maintained and the new behavior should be optional based on a new configuration parameter. - There are no tests to verify the functionality and to mitigate regressions in the future. Take a look at the tests in `src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5` for examples. - There is no documentation to inform users about this configuration option. Documentation should be added to `docs/user-manual/mqtt.adoc`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
