john9x commented on code in PR #5706:
URL: https://github.com/apache/activemq-artemis/pull/5706#discussion_r2105806898
##########
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java:
##########
@@ -139,6 +139,8 @@ public class MQTTUtil {
public static final int DEFAULT_MAXIMUM_PACKET_SIZE = MAX_PACKET_SIZE;
+ public static final int DEFAULT_MAXIMUM_IN_FLIGHT_PUBLISH_MESSAGES = -1; //
-1 means no limit
Review Comment:
@jbertram What do you think about _small_ change of the current behavior -
set `DEFAULT_MAXIMUM_IN_FLIGHT_PUBLISH_MESSAGES` to 65535 ?
In the MQTT protocol it is impossible to send more than 65535 unACKed
PUBLISH.
Before ARTEMIS-5467 -> broker hangs
After ARTEMIS-5467 -> exception and connection closing.
So I think is is not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
