tabish121 commented on code in PR #5772:
URL: https://github.com/apache/activemq-artemis/pull/5772#discussion_r2140997895
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQClientProtocolManager.java:
##########
@@ -499,8 +500,7 @@ public void handlePacket(final Packet packet) {
private void handleDisconnect(SimpleString nodeID, DisconnectReason
reason, SimpleString targetNodeID, TransportConfiguration tagetConnector) {
if (topologyResponseHandler != null) {
- topologyResponseHandler.nodeDisconnected(conn, nodeID == null ?
null : nodeID.toString(), reason,
- targetNodeID == null ? null : targetNodeID.toString(),
tagetConnector);
+ topologyResponseHandler.nodeDisconnected(conn,
Objects.toString(nodeID), reason, Objects.toString(targetNodeID),
tagetConnector);
Review Comment:
Since `Object.toString(x)` returns "null" and not `null` in the case the
value is `null` I'm worried there might be some behavioral changes here that
are not intended. In this case if `nodeID` is null the method will be called
with `nodeID` set to "null" which might not be what was intended, I'd guess
other cases in this PR might see similar side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
