jbertram commented on code in PR #5772:
URL: https://github.com/apache/activemq-artemis/pull/5772#discussion_r2141685863
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQClientProtocolManager.java:
##########
@@ -499,8 +500,7 @@ public void handlePacket(final Packet packet) {
private void handleDisconnect(SimpleString nodeID, DisconnectReason
reason, SimpleString targetNodeID, TransportConfiguration tagetConnector) {
if (topologyResponseHandler != null) {
- topologyResponseHandler.nodeDisconnected(conn, nodeID == null ?
null : nodeID.toString(), reason,
- targetNodeID == null ? null : targetNodeID.toString(),
tagetConnector);
+ topologyResponseHandler.nodeDisconnected(conn,
Objects.toString(nodeID), reason, Objects.toString(targetNodeID),
tagetConnector);
Review Comment:
I'll use `Objects.toString(String, null)` to keep the same semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
