jbertram commented on code in PR #108:
URL:
https://github.com/apache/activemq-artemis-console/pull/108#discussion_r2190233006
##########
artemis-console-war/pom.xml:
##########
@@ -32,6 +32,11 @@
<name>ActiveMQ Artemis Console War</name>
<dependencies>
+ <dependency>
Review Comment:
I tried putting it into the broker's `lib` directory, but Jetty chokes on
this:
```
WARN [org.eclipse.jetty.ee9.webapp.WebAppContext] Failed startup of
context oeje9w.WebAppContext@3719360c{Artemis
Console,/console,file:///path/to/artemis-instance/tmp/webapps/console.war/webapp/,false,@Connector-0}{/path/to/artemis-home/web/console.war}
java.lang.NoClassDefFoundError: org/jolokia/service/jmx/api/CacheKeyProvider
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
at
java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421)
at
java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
at
java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
at
org.eclipse.jetty.ee9.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:474)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:467)
at
org.jolokia.server.core.util.ClassUtil.classForName(ClassUtil.java:66)
at
org.jolokia.server.core.util.ClassUtil.classForName(ClassUtil.java:44)
at
org.jolokia.server.core.util.LocalServiceFactory.createOrRemoveService(LocalServiceFactory.java:171)
at
org.jolokia.server.core.util.LocalServiceFactory.readServiceDefinitionFromUrl(LocalServiceFactory.java:134)
at
org.jolokia.server.core.util.LocalServiceFactory.readServiceDefinitions(LocalServiceFactory.java:118)
at
org.jolokia.server.core.util.LocalServiceFactory.createServices(LocalServiceFactory.java:79)
at
org.jolokia.server.core.service.impl.ClasspathServiceCreator.getServices(ClasspathServiceCreator.java:36)
at
org.jolokia.server.core.service.impl.JolokiaServiceManagerImpl.addServices(JolokiaServiceManagerImpl.java:189)
at
org.jolokia.server.core.http.AgentServlet.initServices(AgentServlet.java:156)
at
org.jolokia.server.core.http.AgentServlet.init(AgentServlet.java:128)
at
io.hawt.web.servlets.JolokiaConfiguredAgentServlet.init(JolokiaConfiguredAgentServlet.java:58)
at
org.eclipse.jetty.ee9.servlet.ServletHolder$Wrapper.init(ServletHolder.java:1307)
at
org.eclipse.jetty.ee9.servlet.ServletHolder.initServlet(ServletHolder.java:634)
at
org.eclipse.jetty.ee9.servlet.ServletHolder.initialize(ServletHolder.java:416)
at
org.eclipse.jetty.ee9.servlet.ServletHandler.lambda$initialize$2(ServletHandler.java:727)
at org.eclipse.jetty.util.ExceptionUtil.call(ExceptionUtil.java:339)
at
org.eclipse.jetty.util.ExceptionUtil$MultiException.callAndCatch(ExceptionUtil.java:277)
at
org.eclipse.jetty.ee9.servlet.ServletHandler.lambda$initialize$3(ServletHandler.java:724)
at
java.base/java.util.stream.SortedOps$SizedRefSortingSink.end(SortedOps.java:357)
at
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:510)
at
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at
java.base/java.util.stream.StreamSpliterators$WrappingSpliterator.forEachRemaining(StreamSpliterators.java:310)
at
java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:735)
at
java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at
org.eclipse.jetty.ee9.servlet.ServletHandler.initialize(ServletHandler.java:752)
at
org.eclipse.jetty.ee9.servlet.ServletContextHandler.startContext(ServletContextHandler.java:364)
at
org.eclipse.jetty.ee9.webapp.WebAppContext.startWebapp(WebAppContext.java:1360)
at
org.eclipse.jetty.ee9.webapp.WebAppContext.startContext(WebAppContext.java:1321)
at
org.eclipse.jetty.ee9.nested.ContextHandler.doStartInContext(ContextHandler.java:698)
at
org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1457)
at
org.eclipse.jetty.ee9.nested.ContextHandler.doStart(ContextHandler.java:682)
at
org.eclipse.jetty.ee9.servlet.ServletContextHandler.doStart(ServletContextHandler.java:278)
at
org.eclipse.jetty.ee9.webapp.WebAppContext.doStart(WebAppContext.java:529)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:113)
at
org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491)
at
org.eclipse.jetty.server.handler.ContextHandler.lambda$doStart$0(ContextHandler.java:762)
at
org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1463)
at
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:762)
at
org.eclipse.jetty.ee9.nested.ContextHandler$CoreContextHandler.doStart(ContextHandler.java:2836)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120)
at
org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.server.Server.start(Server.java:643)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120)
at
org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491)
at org.eclipse.jetty.server.Server.doStart(Server.java:584)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at
org.apache.activemq.artemis.component.WebServerComponent.start(WebServerComponent.java:246)
at
org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.addExternalComponent(ActiveMQServerImpl.java:1025)
at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:146)
at
org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:222)
at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:170)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:149)
at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:61)
Caused by: java.lang.ClassNotFoundException:
org.jolokia.service.jmx.api.CacheKeyProvider
at
java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
... 77 more
```
I didn't want to move a bunch of related jars out of the console and into
the broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
