gemmellr commented on code in PR #127:
URL:
https://github.com/apache/activemq-artemis-console/pull/127#discussion_r2470348646
##########
pom.xml:
##########
@@ -184,6 +186,66 @@
<artifactId>log4j-core</artifactId>
<version>${log4j.version}</version>
</dependency>
+
+ <!-- Jolokia/Artemis integration deps to optimize JSON network
payload, etc. -->
+ <dependency>
+ <groupId>org.jolokia.integration</groupId>
+ <artifactId>jolokia-integration-artemis</artifactId>
+ <version>${jolokia-integration-artemis.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-server-detector</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+
+ <!-- Hawtio-related Jolokia deps to ensure we're not using
multiple versions of Jolokia in the WAR -->
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-json</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-server-core</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-service-serializer</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-service-jmx</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-service-discovery</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-service-history</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-service-jsr160</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-service-notif-pull</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jolokia</groupId>
+ <artifactId>jolokia-service-notif-sse</artifactId>
+ <version>${jolokia.version}</version>
+ </dependency>
Review Comment:
With so many deps, and potential for others appearing later and then not
being managed, maybe using the bom would be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
