jbertram commented on PR #5856: URL: https://github.com/apache/activemq-artemis/pull/5856#issuecomment-3164559577
> I'm having a hard time finding where is the feature integration versus code cleanup and doc improvement. Look for callers of the new methods added to `MetricsManager`. > ...it seems you're just capturing number of tasks directly from the executor service? That's the general idea, but there's a bit more to it. Look at the changes to `metrics.adoc` to see exactly what's being captured. > We use OrderedExecutors, it seems you're not making any integration on the pending tasks from OrderedExecutors? Correct. The integration from Micrometer only applies to instances of `ExecutorService`, not individual instances of `Executor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
