clebertsuconic commented on code in PR #5856:
URL: https://github.com/apache/activemq-artemis/pull/5856#discussion_r2263187619
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java:
##########
@@ -345,10 +338,14 @@ public synchronized void startAcceptors() throws
Exception {
if (isStarted()) {
for (Acceptor a : acceptors.values()) {
try {
- if (a instanceof NettyAcceptor acceptor &&
!acceptor.isAutoStart()) {
+ if (!a.isAutoStart()) {
continue;
}
a.start();
+
+ if (a instanceof NettyAcceptor nettyAcceptor &&
server.getMetricsManager() != null) {
Review Comment:
you could do a similar cleanup to the previous one here.
Create a method on the acceptor such as registerMetrics,
and then change this to
```java
if (server.getMetricsManager() != null) {
a.registerMetrics(server);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
