jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2330719780
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java:
##########
@@ -36,6 +36,8 @@ public class TransportConstants {
public static final String SSL_ENABLED_PROP_NAME = "sslEnabled";
+ public static final String PROXY_ENABLED_PROP_NAME = "proxyEnabled";
Review Comment:
Done.
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java:
##########
@@ -186,26 +188,28 @@ public class TransportConstants {
public static final int STOMP_DEFAULT_CONSUMER_WINDOW_SIZE = 10 * 1024; //
10K
- public static final String PROXY_ENABLED_PROP_NAME = "socksEnabled";
+ public static final String SOCKS_ENABLED_PROP_NAME = "socksEnabled";
- public static final String PROXY_HOST_PROP_NAME = "socksHost";
+ public static final String SOCKS_HOST_PROP_NAME = "socksHost";
- public static final String PROXY_PORT_PROP_NAME = "socksPort";
+ public static final String SOCKS_PORT_PROP_NAME = "socksPort";
public static final String PROXY_VERSION_PROP_NAME = "socksVersion";
- public static final String PROXY_USERNAME_PROP_NAME = "socksUsername";
+ public static final String SOCKS_USERNAME_PROP_NAME = "socksUsername";
- public static final String PROXY_PASSWORD_PROP_NAME = "socksPassword";
+ public static final String SOCKS_PASSWORD_PROP_NAME = "socksPassword";
- public static final String PROXY_REMOTE_DNS_PROP_NAME = "socksRemoteDNS";
+ public static final String SOCKS_REMOTE_DNS_PROP_NAME = "socksRemoteDNS";
public static final String AUTO_START = "autoStart";
public static final boolean DEFAULT_AUTO_START = true;
public static final boolean DEFAULT_SSL_ENABLED = false;
+ public static final boolean DEFAULT_PROXY_ENABLED = false;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact