jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2344551515
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/util/CFUtil.java:
##########
@@ -26,13 +26,24 @@ public class CFUtil {
public static ConnectionFactory createConnectionFactory(String protocol,
String uri) {
if (protocol.toUpperCase().equals("OPENWIRE")) {
return new org.apache.activemq.ActiveMQConnectionFactory(uri);
+ } else if (protocol.toUpperCase().equals("OPENWIRE_SSL")) {
+ if (uri.startsWith("tcp://")) {
+ // replacing tcp:// by amqp://
Review Comment:
I simplified this code and removed the comment.
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/util/CFUtil.java:
##########
@@ -26,13 +26,24 @@ public class CFUtil {
public static ConnectionFactory createConnectionFactory(String protocol,
String uri) {
if (protocol.toUpperCase().equals("OPENWIRE")) {
return new org.apache.activemq.ActiveMQConnectionFactory(uri);
+ } else if (protocol.toUpperCase().equals("OPENWIRE_SSL")) {
+ if (uri.startsWith("tcp://")) {
+ // replacing tcp:// by amqp://
+ uri = "ssl" + uri.substring(3);
+ }
+ return new org.apache.activemq.ActiveMQSslConnectionFactory(uri);
} else if (protocol.toUpperCase().equals("AMQP")) {
-
if (uri.startsWith("tcp://")) {
// replacing tcp:// by amqp://
uri = "amqp" + uri.substring(3);
}
return new JmsConnectionFactory(uri);
+ } else if (protocol.toUpperCase().equals("AMQPS")) {
+ if (uri.startsWith("tcp://")) {
+ // replacing tcp:// by amqp://
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
