davidvoit commented on code in PR #34:
URL: https://github.com/apache/activemq-nms-api/pull/34#discussion_r2529709762
##########
src/nms-api/NMSConnectionFactory.cs:
##########
@@ -75,6 +75,10 @@ static NMSConnectionFactory()
new ProviderFactoryInfo("Apache.NMS.ZMQ",
"Apache.NMS.ZMQ.ConnectionFactory");
schemaProviderFactoryMap["amqp"] =
new ProviderFactoryInfo("Apache.NMS.AMQP",
"Apache.NMS.AMQP.ConnectionFactory");
+ schemaProviderFactoryMap["amqps"] =
+ new ProviderFactoryInfo("Apache.NMS.AMQP",
"Apache.NMS.AMQP.ConnectionFactory");
+ schemaProviderFactoryMap["failover"] =
Review Comment:
Wouldn't this be activemq:failover then? We could also implement a second
level lookup if needed. look for tcp/ssl or amqp/amqps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
