davidvoit commented on code in PR #34:
URL: https://github.com/apache/activemq-nms-api/pull/34#discussion_r2536899595
##########
src/nms-api/NMSConnectionFactory.cs:
##########
@@ -75,6 +75,10 @@ static NMSConnectionFactory()
new ProviderFactoryInfo("Apache.NMS.ZMQ",
"Apache.NMS.ZMQ.ConnectionFactory");
schemaProviderFactoryMap["amqp"] =
new ProviderFactoryInfo("Apache.NMS.AMQP",
"Apache.NMS.AMQP.ConnectionFactory");
+ schemaProviderFactoryMap["amqps"] =
+ new ProviderFactoryInfo("Apache.NMS.AMQP",
"Apache.NMS.AMQP.ConnectionFactory");
+ schemaProviderFactoryMap["failover"] =
Review Comment:
But failover: are currently so or so not working. I think it would be fine
to conenect it to amqp and go with activemq:failover for openwire as the new
default. What do you think, should we write some new uri parsind and decsision
logick or would this new default be fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
