cshannon commented on PR #1552: URL: https://github.com/apache/activemq/pull/1552#issuecomment-3590183004
Can you mark PRs as "draft" for work in progress stuff? It will make it easier to know when it's ready for review. Also, KahaDB already has a max journal length setting so I was wondering if that could be used may it may not be able but it has been a while since I looked. I think if a record is bigger than the max length I believe it will just write the entire value and be larger than the configured max. So we may need to enforce a max or something. Something else is the journal file length max size can be changed between restarts so you could have different size files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
