jeanouii commented on PR #1552: URL: https://github.com/apache/activemq/pull/1552#issuecomment-3598754293
@cshannon sorry about that. Sure thing I'll be more diligent. I discovered this while debugging a test randomly failing with out of memory. Yes, KahaDB already has a max length and the idea is to use it to cap the record length. If the file is corrupted in a way that the record length is very large, we may blow up the memory. The idea here is to cap the record size to the file max size. If your assumption is correct then my fix won't work, and it will fail even though the record was accurately written to disk in a bigger file. We need a cap on the record size in my opinion. But I'm not sure what's the best at the minute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
