jeanouii commented on code in PR #1541:
URL: https://github.com/apache/activemq/pull/1541#discussion_r2608517850
##########
activemq-mqtt/pom.xml:
##########
@@ -293,6 +294,70 @@
</plugins>
</build>
</profile>
+ <profile>
Review Comment:
Yes the initial purpose was to have a PR that runs the exact same test suite
as main, without having to enable or disable a profile.
Introducing a profile duplicates the configuration and can be a worry for
test coverage as you pointed out.
The project has already a lot of profiles, excludes in tests, etc. I don't
think adding one more for that was necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
