rmannibucau commented on code in PR #1541:
URL: https://github.com/apache/activemq/pull/1541#discussion_r2609871358
##########
activemq-mqtt/pom.xml:
##########
@@ -293,6 +294,70 @@
</plugins>
</build>
</profile>
+ <profile>
Review Comment:
profile is likely to not be ran when contributing/rebuilding so it is always
a bad practise when setting up a test suite. Profiles are really for what can't
run by default because it needs something special (latest nvidia gpu for ex to
be trendy). There, there is no reason since it do run, it just needs another
execution if you think it is worth splitting - my 2 cts would be I would make
it working in the default execution to ensure a smooth integration in the IDE
for contributors but this is more a habit/preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
