cshannon commented on code in PR #2006:
URL: https://github.com/apache/activemq/pull/2006#discussion_r3230162132
##########
activemq-broker/src/main/java/org/apache/activemq/security/AuthorizationBroker.java:
##########
@@ -75,12 +75,22 @@ protected SecurityContext
checkSecurityContext(ConnectionContext context) throws
return securityContext;
}
- protected boolean checkDestinationAdmin(SecurityContext securityContext,
ActiveMQDestination destination) {
- Destination existing =
this.getDestinationMap(destination).get(destination);
- if (existing != null) {
+ protected boolean checkDestinationAdminAdd(SecurityContext
securityContext, ActiveMQDestination destination) {
+ if (this.getDestinationMap(destination).get(destination) != null) {
+ return true;
+ }
+
Review Comment:
Minor nit, might want to remove this empty line to be consistent with
checkDestinationAdminRemove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
