cshannon commented on PR #2006: URL: https://github.com/apache/activemq/pull/2006#issuecomment-4435272860
This looks ok to me as long as tests are good. I looked at the core logic changes and they look correct so that the short circuit now looks good (it short circuits on remove if the dest doesn't exist and short circuits on add if the dest already exists) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
