cshannon commented on PR #2071:
URL: https://github.com/apache/activemq/pull/2071#issuecomment-4617478145
> 1. Destinations send advisories -- all methods except
'onMessagegWithNoConsumer' process through the Broker API.
>
> ```
> protected void onMessageWithNoConsumers(ConnectionContext context, Message
msg) throws Exception {
@mattrpav - Very good catch! I missed that, the solution here is pretty
simple, we need to just move this code inside the AdvisoryBroker, I have no
idea why it's not there in the first place so I will fix this.
>
> 2. StatisticsBroker sends advisories -- using the client connection
context here seems appropriate
> 3. Scheduler jobs are technical advisory messages. This too looks ok as it
sends it back through the broker.
Both of theses send the messages to temporary destinations and by default
the broker allows all users to create and use temporary destinations unless
restricted so it probably doesn't matter one way or the other. I guess an
argument could be made that both could/should use the broker context as well as
the broker is sending the messages back but due to the temporary target I don't
think it matters and maybe we leave it alone for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
