cshannon commented on code in PR #2071:
URL: https://github.com/apache/activemq/pull/2071#discussion_r3358111245
##########
activemq-broker/src/main/java/org/apache/activemq/broker/Broker.java:
##########
@@ -370,6 +370,14 @@ public interface Broker extends Region, Service {
*/
void messageDiscarded(ConnectionContext context, Subscription sub,
MessageReference messageReference);
+ /**
+ * Called when a message is processed with no consumers
+ *
+ * @param context connection context
+ * @param messageReference message reference
+ */
+ void messageNoConsumers(ConnectionContext context, MessageReference
messageReference);
Review Comment:
My assumption is that almost everyone is using BrokerFilter for writing
plugins and just extending that. I doubt many people are implementing this
interface as then they would have to implement every method themselves. We
could make the method have a no-op default but I don't really like that because
then anyone who is implementing directly wouldn't know about it.
The way to avoid this is to not move the logic into the AdvisoryBroker in
the minor releases, and instead just look up the admin context from the broker
each time one of those advisories is fired.
I can revert that change and then make a follow on when this is merged that
will move this logic into the AdvisoryBroker and add the new method for version
6.3.0 only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
