hai-ben commented on PR #2402: URL: https://github.com/apache/activemq/pull/2402#issuecomment-5347266855
@mattrpav > The write take data from the broker unsanitized. So things like brokerName, queue/topic names, and clientIds are all user-defined strings that create attack surface for malformed json. What I was missing was that users that create destinations on the broker would be different than users consuming metrics. And a bad sanitizer could let the former break the latter. Prometheus output isn't JSON, but I'll swap to the official Prometheus parser/output library to address the concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
