mattrpav commented on code in PR #2133:
URL: https://github.com/apache/activemq/pull/2133#discussion_r3935112058
##########
activemq-client/src/main/java/org/apache/activemq/transport/failover/FailoverTransportFactory.java:
##########
@@ -43,6 +45,18 @@ public Transport doConnect(URI location) throws IOException {
}
}
+ @Override
+ public Transport doConnect(URI location, SslContext sslContext) throws
Exception {
Review Comment:
Two problems at this specific location:
1. The other doConnect methods throw Exception and not IOException
2. There are two doConnect method with 2-params.
I'm good with dropping the dupe code, but we'd need to be ok w/ wrapping the
exception and casting (SslContext)null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
