cshannon commented on code in PR #2133:
URL: https://github.com/apache/activemq/pull/2133#discussion_r3935215099
##########
activemq-client/src/main/java/org/apache/activemq/transport/failover/FailoverTransportFactory.java:
##########
@@ -43,6 +45,18 @@ public Transport doConnect(URI location) throws IOException {
}
}
+ @Override
+ public Transport doConnect(URI location, SslContext sslContext) throws
Exception {
Review Comment:
So my next question is why is it different with the exception handling, I
didn't notice that but shouldn't all the new methods being throw IOException
and not Exception so it's consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
