hai-ben commented on PR #2402: URL: https://github.com/apache/activemq/pull/2402#issuecomment-6600273534
Thanks for the comments @mattrpav. I've made updates except for: > dbl check we don't need to close the stream or use try-with-resources here. verify servlet does that per-spec It did a quick test and it looks like the server does behave by spec (I didn't add it because a unit test that a dependency follows spec is a little extra). The streams handler in the servlet does full lifecycle management and a try-with-resource block sends a false "OK" in the case of an error. > 6.4.0 release is wrapping up now, so this can go into 6.5.0 (and it looks like it's already tagged with 6.5.0) Sounds great! Excited to get this merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
