mattrpav commented on PR #2402: URL: https://github.com/apache/activemq/pull/2402#issuecomment-5848901391
I'm leaning towards experimenting with adding this. I think it is good exposure and some end-users see it as 'table stakes' vs the jmx_exporter approach. - [ ] Use constants for field names where possible instead of strings - [ ] Re-use existing helpers for crafting JMX object names vs using the current stringified approach - [ ] Add serious input validation (null check, length, regex, etc) and input value escaping before passing the object names to JMX queries. - [ ] DestinationTypes should map exactly to the internal strings 'queue', 'topic', 'temp-queue', 'temp-topic', and not relabel them to a new string form. - [ ] Add tests that verify the prometheus metrics model data is rendered exactly against a test that uses those classes on unmarshal. This is to catch any regression or breaking changes in the prometheus dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
