sankarh commented on a change in pull request #579: HIVE-21109 : Support stats replication for ACID tables. URL: https://github.com/apache/hive/pull/579#discussion_r270652339
########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestStatsReplicationScenarios.java ########## @@ -216,16 +233,23 @@ private void verifyNoPartitionStatsReplicationForMetadataOnly(String tableName) String ndTableName = "ndTable"; // Partitioned table without data during bootstrap and hence no stats. String ndPartTableName = "ndPTable"; + String tblCreateExtra = ""; + + if (useAcidTables) { Review comment: We can add one more test set for MM (insert-only ACID tables). Also, ACID table stats tests should cover few more operations. 1. Delete and update on Full ACID tables. 2. Insert overwrite, Truncate. 3. LOAD DATA, Import. 4. CTAS. 5. MERGE. 6. ADD/REMOVE columns. 7. Table/partition renames (Need to see, if REPL LOAD of rename event takes care of stats too.) Note, we need to run dump and load after each operation to check if the stats are consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org