sankarh commented on a change in pull request #579: HIVE-21109 : Support stats replication for ACID tables. URL: https://github.com/apache/hive/pull/579#discussion_r270819437
########## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ########## @@ -2950,21 +2957,32 @@ public Partition createPartition(Table tbl, Map<String, String> partSpec) throws int size = addPartitionDesc.getPartitionCount(); List<org.apache.hadoop.hive.metastore.api.Partition> in = new ArrayList<org.apache.hadoop.hive.metastore.api.Partition>(size); - AcidUtils.TableSnapshot tableSnapshot = AcidUtils.getTableSnapshot(conf, tbl, true); long writeId; String validWriteIdList; - if (tableSnapshot != null && tableSnapshot.getWriteId() > 0) { - writeId = tableSnapshot.getWriteId(); - validWriteIdList = tableSnapshot.getValidWriteIdList(); + + // In case of replication, get the writeId from the source and use valid write Id list + // for replication. + if (addPartitionDesc.getReplicationSpec().isInReplicationScope() && + addPartitionDesc.getPartition(0).getWriteId() > 0) { Review comment: I think, this assumption of table type is non-transactional (based on writeId=0) and ignoring failure case is not right. We can explicitly check if it is transactional table or not and then do necessary checks. If writeId comes as 0 for transactional table, then it is error flow. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org